search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
30 stars 77 forks source link

nodeset to watch certs it owns #991

Closed stuggi closed 3 months ago

stuggi commented 3 months ago

The dataplanedeploynet creates the certificates and set the nodeset as the owner. The nodeset should reconcile when the cert changes

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, fao89, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [abays,fao89,stuggi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
fao89 commented 3 months ago

/lgtm

stuggi commented 3 months ago

the nodeset is not creating or consuming the certs, so should be not required. the deployment is managing the certs. it should watch them