search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
30 stars 77 forks source link

Add watcher for cert changes #992

Closed vakwetu closed 3 months ago

vakwetu commented 3 months ago

The deployment manages certs and needs to watch them for changes during the initial deployment.

Jira: OSPRH-9089

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slagle, vakwetu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [slagle] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vakwetu commented 3 months ago

/retest

stuggi commented 3 months ago

/cherry-pick 18.0.0-proposed

openshift-cherrypick-robot commented 3 months ago

@stuggi: #992 failed to apply on top of branch "18.0.0-proposed":

Applying: Add watcher for cert changes
Using index info to reconstruct a base tree...
M   controllers/dataplane/openstackdataplanedeployment_controller.go
M   tests/functional/dataplane/suite_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/functional/dataplane/suite_test.go
Auto-merging controllers/dataplane/openstackdataplanedeployment_controller.go
CONFLICT (content): Merge conflict in controllers/dataplane/openstackdataplanedeployment_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add watcher for cert changes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openstack-k8s-operators/openstack-operator/pull/992#issuecomment-2268218643): >/cherry-pick 18.0.0-proposed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.