openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Replace Ceilometer's ProxyImage with a generic one to avoid duplicati… #999

Closed jlarriba closed 1 month ago

jlarriba commented 1 month ago

…on of related images

jlarriba commented 1 month ago

/hold

As discussed with Dan, I am not really comfortable of having Octavia and Telemetry sharing the same image, as that could mean that the image gets updated by one of the teams unkowingly to the other, and that can cause issues.

Sharing images is this going to be a pattern for all services?

dprince commented 1 month ago

/hold

As discussed with Dan, I am not really comfortable of having Octavia and Telemetry sharing the same image, as that could mean that the image gets updated by one of the teams unkowingly to the other, and that can cause issues.

Sharing images is this going to be a pattern for all services?

My viewpoint on this is it is an Apache image (pretty basic service) so probably okay to share it right? And if down the road we need to isolate and have multiple settings referring to different container images so be it... we can.

One more detail, the HTTP image would actually get used in 3 places: baremetal-operator(the original reason we have it), telemetry-operator, and then octavia as well.

dprince commented 1 month ago

@jlarriba code here looks good. Aside from your question I am LGTM to merge this.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, jlarriba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [dprince] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jlarriba commented 1 month ago

/unhold