openstacknetsdk / openstack.net

An OpenStack Cloud SDK for Microsoft .NET
http://www.openstacknetsdk.org
Other
117 stars 101 forks source link

Allow Newtonsoft.Json 10.x #653

Closed johnrutherford closed 7 years ago

johnrutherford commented 7 years ago

I think it is best to just remove the maximum version number for Newtonsoft.Json. Most other NuGet packages I have looked at use this approach with Newtonsoft.Json.

I'm also happy to change the range to be "[6.0.1,11.0)", if that's what the maintainers would prefer. But since this project doesn't seem very actively maintained, I think just removing the max version will allow more people to continue to use it without this being a recurring issue.

dwalleck commented 7 years ago

I think opening up the ceiling for versions should be fine unless we run into problems with backwards compatibility at some point. For now, I think this should be fine.

johnrutherford commented 7 years ago

@dwalleck, can we get a new NuGet release with this change?

oguimbal commented 6 years ago

+1 ?

panuva-sympa commented 6 years ago

I'm giving a hand to @dwalleck to make a new build. In the meanwhile, anyone using paket framework and facing the issue still a workaround would be to lock the Newtonsoft.Json to a specific release in paket.dependencies, like

nuget Newtonsoft.Json == 11.0.2 

(downside, you won't get automatically updating Newtonsoft.Json package though)