openstad / openstad-kubernetes

The Kubenernetes YAML files and the Helm chart for automated full stack deployment
https://www.open-stad.amsterdam/projecten/#
MIT License
4 stars 7 forks source link

feat: allow user to add extra environment variables per service #79

Closed Badmuts closed 2 years ago

Badmuts commented 2 years ago

This allows users to set extra environment variables through the values.yml file. We use some extra environment variables for our installation of the OpenStad Amsterdam cluster. With this changes we no longer have to change the helm templates and can specify other values per environment.

Tested with k8s 1.22 and k8s 1.25

rudivanhierden commented 2 years ago

I tested this PR with helm lint and helm template, but did not apply the template to a cluster. @Badmuts Did you test the resulting template by applying it against a cluster?

Badmuts commented 2 years ago

I haven't tested it on a real cluster yet, that is why I made some specific changes so I could release this on my fork. Will test this today

Badmuts commented 2 years ago

I have tested this with a kind cluster (k8s: 1.25) and a development cluster (k8s: 1.22), haven't had problems so far