openstate / jodal

Open gov data platform for journalists: all government data — monitor, filter, forward. (FKA jodal)
https://bron.live
6 stars 1 forks source link

Dead links to PDF docs from ORI source #149

Open vanderburgt opened 11 months ago

vanderburgt commented 11 months ago

Describe the bug

Summary Results from the ORI source link to PDF docs that are not available.

URL / Environment https://bron.live

Steps to reproduce**

  1. Go to bron.live
  2. Replace 'Windmolens' with 'Marineterrein'
  3. Scroll down to result preview
  4. See latest result from March 2022
  5. Click on result and click on 'Ga naar bron' button (English: 'Open source')
  6. See message: 'No Results found'

Expected behavior

The relevant result is show and the PDF is available for download.

Screenshots

https://github.com/openstate/jodal/assets/8989205/41d7508b-3ec8-48ad-b5e9-48a35115f693

Additional information

Possibly related to #148

breyten commented 10 months ago

There was no way to store a document url separate from a link. This functionality has been added. Document urls will be fetched from January 200 (as well as for new documents) in order to prevent having to recrawl the enite obv database. Still needs a minor frontend change.

breyten commented 10 months ago

Document urls are presented where available instead . Note that this will sometimes still result in file not found errors, since documents can apparently be deleted. Not sure why. This could be remedied by placing a small proxy in between to check the links

breyten commented 10 months ago

Older documents are being fetched right now ...