search

openstate / open-cultuur-data

The back- and front-end code that powers the Open Cultuur Data API
http://opencultuurdata.nl/
28 stars 18 forks source link

OpenBeeldenOaiExtractor has become obsolete #34

Closed mickdelange closed 10 years ago

mickdelange commented 10 years ago

I saw that the OpenBeeldenOaiExtractor (in ocd_bakcend.extractors.oai.OpenBeeldenOaiExtractor) was created to deal with an error which is caused when sending the metadataPrefix as parameter when there is also a resumptionToken present in the request.

This same error was dealt with in the implementation as described in PR #31. I also tested this by editing the resources.json to let openbeelden use the regular OaiExtractor, this functioned correctly.

breyten commented 10 years ago

Can you make a pull request for this? :) (I was thinking the same thing, but now focussing on merging other PRs)

mickdelange commented 10 years ago

Yes, will do!