search

openstate / open-cultuur-data

The back- and front-end code that powers the Open Cultuur Data API
http://opencultuurdata.nl/
28 stars 18 forks source link

Code for opencultuurdata.nl #68

Closed askmike closed 10 years ago

askmike commented 10 years ago

We have a bugfix we want to apply to the wordpress theme behind opencultuurdata.nl. However this repo appears to only contain the source code of the open-cultuur-data API.

Is it possible to submit a PR for opencultuurdata.nl?

/cc @MScMSc

ajslaghu commented 10 years ago

Hi Mike, I would definitely hope so! Unfortunately, our lead programmer is out of the office, so It can take some time.

bartdegoede commented 10 years ago

This repository specifically contains source code for the OpenCultuurData API, not the Wordpress installation. There probably is a specific repository for the Wordpress, and @breyten can probably point you to that :-)

askmike commented 10 years ago

The big "Fork me on github" ribbon on the wordpress website points to this repo. Maybe we can fix that link while we're at it?

On Mon, Nov 24, 2014 at 3:26 PM, Bart de Goede notifications@github.com wrote:

This repository specifically contains source code for the OpenCultuurData API, not the Wordpress installation. There probably is a specific repository for the Wordpress, and @breyten https://github.com/breyten can probably point you to that :-)

— Reply to this email directly or view it on GitHub https://github.com/openstate/open-cultuur-data/issues/68#issuecomment-64200288 .

bartdegoede commented 10 years ago

Excellent point. @breyten ? :-)

breyten commented 10 years ago

I don't know where we have it, but luckily someone in the office knew who actually built the theme, so I've asked for the repo's location :)

mzeinstra commented 10 years ago

Breyten refers to me, while I have set up the site I have not made the theme. It is a derivative of http://wpshower.com/themes/imbalance-2/ with some css and plugins to change the appearance.

What is it that you want to fix?

askmike commented 10 years ago

The original bug was about big images in pages, like this one. But now additionally I would also consider the "Fork me on Github" ribbon a bug, since the code is not open source (nor forkable).

On Tue, Nov 25, 2014 at 10:03 AM, Maarten Zeinstra <notifications@github.com

wrote:

Breyten refers to me, while I have set up the site I have not made the theme. It is a derivative of http://wpshower.com/themes/imbalance-2/ with some css and plugins to change the appearance.

What is it that you want to fix?

— Reply to this email directly or view it on GitHub https://github.com/openstate/open-cultuur-data/issues/68#issuecomment-64328296 .

mzeinstra commented 10 years ago

I've changed the image at the link you refer to. I would put that to bad editing.

I see that the fork me ribbon is indeed misleading. I'll let that to the people at Open State solve that issue. I don't have the permissions to change that on the server.

Cheers,

Maarten

bartdegoede commented 10 years ago

Seems to be fixed. Thanks Maarten!

askmike commented 10 years ago

Maarten, thanks for fixing that specific post. I should have clarified that the bug was not an isolated case and this issue can be found on more pages (1, 2, 3, 4, 5, 6, 7, 8 just to name a few).

A good way of solving this is to limit the max image size through Wordpress media options. Alternatively this simple css would at least hide the bug from the UI:

.post img {
  max-width: 710px;
  height: auto;
}

Also for the Ribbon, should I create a new issue for this?

bartdegoede commented 10 years ago

I don't think that those are issues to handle in this particular repository, since it contains the source code of the OpenCultuurData API, and not of the OpenCultuurData blog. It seems like the image issue is either about something in the Wordpress theme, or about some editorial/configuration issue in the Wordpress site (which is not maintained here), so I would say that either the site admin should fix it, or that a fix is submitted to the maintainer of the Wordpress theme.

With regard to the ribbon, I agree that linking to this particular repository might be confusing, but again, I don't think it is an issue that is relevant to the API.

I do appreciate the effort and interest though :-)

askmike commented 10 years ago

Thanks for the quick replies Bart. As a final question: do you happen to have any idea where I can raise the ribbon issue?

On Tue, Nov 25, 2014 at 2:16 PM, Bart de Goede notifications@github.com wrote:

I don't think that those are issues to handle in this particular repository, since it contains the source code of the OpenCultuurData API http://www.opencultuurdata.nl/api/, and not of the OpenCultuurData blog. It seems like the image issue is either about something in the Wordpress theme, or about some editorial/configuration issue in the Wordpress site (which is not maintained here), so I would say that either the site admin should fix it, or that a fix is submitted to the maintainer of the Wordpress theme.

With regard to the ribbon, I agree that linking to this particular repository might be confusing, but again, I don't think it is an issue that is relevant to the API.

I do appreciate the effort and interest though :-)

— Reply to this email directly or view it on GitHub https://github.com/openstate/open-cultuur-data/issues/68#issuecomment-64397691 .

bartdegoede commented 10 years ago

Unfortunately, no. I was hoping @breyten knew about a repository somewhere, but I’m afraid there isn’t one. I think the quickest/most effective way is contacting the site admins directly through their contact form, or ping @ajslaghu