search

openstates / openstates-scrapers

source for Open States scrapers
https://openstates.org
GNU General Public License v3.0
846 stars 464 forks source link

VA: comma issue with names? #167

Closed ninapsoncak closed 12 years ago

ninapsoncak commented 12 years ago

http://openstates.org/browse/va/2011/HB%201585/2 VA is mis-counting things: http://lis.virginia.gov/cgi-bin/legp604.exe?111+vot+H08V0129+HB1585 there are 22 names in the YEAS?

For other "bad votes", might be appearing as wrong because initials are being separated by commas... Otherwise, this should be correct: http://openstates.org/browse/va/2011/HB%202099/ http://lis.virginia.gov/cgi-bin/legp604.exe?111+vot+H11V0056+HB2099

For all of these, too: http://openstates.org/browse/va/2011/HB%202316/ http://openstates.org/browse/va/2012/SB%20432/ http://openstates.org/browse/va/2010/HB%20908/ http://openstates.org/browse/va/2012/HB%20459/

paultag commented 12 years ago

triaged, thanks!

swenson commented 12 years ago

Also, the sponsor-less ones seem to have been fixed. Added tests.

ninapsoncak commented 12 years ago

bad vote counts remain: In some cases upstream issue, as with 2010 HB1 http://lis.virginia.gov/cgi-bin/legp604.exe?101+sum+HB1 http://openstates.org/admin/va/bills/2010/HB%201/

Other times bad count appearing probably because of commas, as with 2012 SB432 http://lis.virginia.gov/cgi-bin/legp604.exe?121+sum+SB432 http://openstates.org/admin/va/bills/2012/SB%20432/

jamesturk commented 12 years ago

a fix for this was committed, needs to be checked (& re-ran for prior sessions)

jamesturk commented 12 years ago

had the name split wrong, trying again today

jamesturk commented 12 years ago

still a WIP - running on an old session to see what it looks like, the 7 hour run time for VA makes this a pain

jamesturk commented 12 years ago

a few exceptions added, but solved comma issue