Closed Skye967 closed 2 days ago
@Skye967 is attempting to deploy a commit to the OpenStatus Team on Vercel.
A member of the Team first needs to authorize it.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
openstatus-web | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 5, 2024 8:41pm |
Thanks for the feedback, I think I did it that way because I also was have problems using next/navigation, I'll double check that and try put it on the server side. I'll change it to the shadcn ui component.
Thanks for the feedback, I think I did it that way because I also was have problems using next/navigation, I'll double check that and try put it on the server side. I'll change it to the shadcn ui component.
Sounds good! Feel free to point out your issue with next/navigation
(either within the PR or via Discord DM).
I think I did it how you suggested. I was going to use the shadcn ui, but I noticed there was some pagination components in the local directory. I decided on making the ListPagination component to utilize the pagination components which also had the right ui style consistency.
Adjusted the list-pagination component and added zod validation to the changelog and blog. I also made copies of the pagination and button components and put them in @openstatus/ui. I moved the list-pagination to the bottom of the pages.
I think the build step should be working. I can't test it properly because I have no Sentry auth token configured. I changed the pagination component to use the next Link tag. I had to install the dependency in the directory.
Hey @Skye967, sorry for keeping you waiting. I'll be back from vacation end of the week and will have some time to follow up! I will test it locally and if that's ok for you I'll commit the last fixes on top of it! Thanks for your work so far.
Hey @Skye967! Feel free to have a look at the final changes. Thanks for your work here and apologies it took so long. 🙏
Type of change
When we are on the openstatus.dev/changelog or openstatus.dev/blog we added pagination to show only the last 10 entries.
Description
A picture tells a thousand words (if any)
Before this PR
After this PR
Related Issue (optional)
https://github.com/openstatusHQ/openstatus/issues/923