search

openstatusHQ / openstatus

🏓 The open-source synthetic monitoring platform 🏓
https://openstatus.dev
GNU Affero General Public License v3.0
6k stars 378 forks source link

post-deleting a monitor a UI exception is thrown #944

Closed SeanCassiere closed 1 month ago

SeanCassiere commented 1 month ago

Reproduction / Replay Link (Optional)

No response

Description

Steps to reproduce:

  1. Create a monitor.
  2. Click on the monitor.
  3. Navigate to "Setting" from the sidebar.
  4. Select the tab labelled as "Danger".
  5. Click on the button labelled as "Delete" and confirm the action in the dialog that pops up.
  6. Observe the deletion go through and then the exception be thrown.

Expected behavior:

It should probably redirect you to the monitors list page or whatever post-deletion flow was intended here.

Actual behavior:

An exception is thrown on and displays the Next error screen.

image

I'd record a video, but after the deletion, I found out that the number of allowed monitors on the Hobby Plan has been reduced, and I don't want to remove the remaining ones that I have.

Environment

No response

SeanCassiere commented 1 month ago

Console dump: www.openstatus.dev-1721559244679.log

PS: I do have Adblock enabled.

mxkaske commented 1 month ago

Thanks for sharing. Will check.

mxkaske commented 1 month ago

Fixed! We usually delete from the tables and then only need to do a router.refresh. In this case, we where trying to fetch an entry that doesn't exists.

We might wanna rework the error handling on app side to provide more valuable messages to the user.