search

openstax / cnx-recipes

The extended CSS recipes for cooking openstax books
https://packages.cnx.org/cnx-rulesets/latest/
GNU Lesser General Public License v2.1
5 stars 14 forks source link

cookbook - issues with checks failing on github / codecov #5516

Open lwtchu opened 2 months ago

lwtchu commented 2 months ago

original slack thread: https://openstax.slack.com/archives/C022NETP39N/p1713183865690299

checks are passing locally but failing on codecov. tests are passing according to logs but failing in the ping to codecov.

approach: will continue to merge PRs so long as checks pass locally and we might need to look into our versioning of codecov

lwtchu commented 2 months ago

Waiting for phil to come back

therealmarv commented 2 months ago

I will try to fix this short term with this approach https://openstax.slack.com/archives/C0LA54Q5C/p1714059852121119?thread_ts=1714059000.909419&cid=C0LA54Q5C

long-term approach is to get rid of codecov (in Cookbook and Enki) and a new card will be created (link will follow).

therealmarv commented 2 months ago

Actually I cannot do the short term fix because of lack of permissions :(

@philschatz if you don't mind can you add the secret from CodeCov for Cookbook into GitHub settings in Cookbook. Here is a tutorial: https://docs.codecov.com/docs/adding-the-codecov-token

Once the secret is internally in GitHub settings I can reactivate Codecov.

therealmarv commented 2 months ago

Link to card (in CE) for the ultimate fix (add Code coverage to GH actions): https://github.com/openstax/ce/issues/2214

lwtchu commented 1 month ago

@therealmarv Hello - is there any status on the card above? No rush - just wondering

openstaxalina commented 1 day ago

hey @therealmarv I wanted to check in on this -- any update?

therealmarv commented 22 hours ago

I will release a PR for a part on Wednesday. However I've hit a wall with some other parts of the coverage which needs more dev time.

My current recommendation is to fulfill the secret to codecov to get a short term fix :/ (as explained before) and then do the long-term fix.