search

openstax / exchange-ruby

Ruby client for Exchange API
MIT License
1 stars 1 forks source link

Remove exercise source validation unless absolutely necessary #14

Open jpslav opened 9 years ago

jpslav commented 9 years ago

https://github.com/openstax/exchange-ruby/blob/master/lib/openstax/exchange/fake_client/fake_client.rb#L55

In some test data I had a different URL, and this blew up. I don't know why we really need to check this.

kevinburleigh75 commented 9 years ago

We check it because the server checks it. Has that been removed?

We want the fake and real clients to behave as identically as possible.

Dantemss commented 9 years ago

I made it a little more lenient for convenience. The fake client will accept anything ending in openstax.org or localhost.