openstax / oer.exports

Converter to various book formats (PDF, epub, mobi)
2 stars 0 forks source link

All Titles: Preface styling should match header styling in rest of book #1264

Closed openstaxalina closed 8 years ago

openstaxalina commented 9 years ago

We have noticed header styling is visually confusing in multiple book prefaces. Example screenshots from PreAlgebra attached. Per @nyxer95, preface styling should match styling throughout the rest of the title.

screen shot 2015-09-22 at 11 11 55 am screen shot 2015-09-22 at 11 12 05 am
openstaxalina commented 9 years ago

(assigned two "place" labels - not sure where this change would occur)

brittweinstein commented 9 years ago

Here are my findings after Preface testing. When everything after < content > is included in one large < section >, the numbering before H1 is removed. However, this causes some new issues to arise with styling consistencies.

For example, using the Biology parameter, H2 becomes italicized: screen shot 2015-10-15 at 2 55 31 pm In History, American Government, and Psychology H2 are the same size as H1:

screen shot 2015-10-21 at 5 08 50 pm

This does not change when the all encompassing < section > tag is removed, or when an empty < label/ >tag is assigned.

openstaxalina commented 9 years ago

Makes sense - Thanks!

@InconceivableVizzini @helenemccarron @zroehr who owns the US History/AmGov/Psychology templates? It seems H1s and H2s are styled the same in those templates. For the cnxml in the Preface to be correct, we would use H1s and H2s and the styling would look odd.

zroehr commented 8 years ago

Are we still aiming to complete this in liberal.llama?

brittweinstein commented 8 years ago

Physics, Sociology, Biology, Anatomy, Statistics, Econ, and AP Physics are resolved.

Microbiology, Basic Math, Chemistry, University Physics, Precalculus, Astronomy, and Calculus are resolved after an all encompassing < section > tag is added.

Psychology, History, and American Government are not resolved. See issue #1335

nyxer95 commented 8 years ago

This change will affect the following:

(17 books)