openstax / oer.exports

Converter to various book formats (PDF, epub, mobi)
2 stars 0 forks source link

Physics => random font increase inside Problems & Exercises #1685

Closed kerwinso closed 8 years ago

kerwinso commented 8 years ago

http://legacy-textbook-dev.cnx.org/content/col10003/latest/

This one sentence has increased font size, affecting readability. Appears to be an isolated case.

Doesn't look like math...?

image

Also, this may possibly be related to #1560? Or #1689

InconceivableVizzini commented 8 years ago

This seems to be a case where PrinceXML abandoned a specific implementation of rendering multiple-column content. In the "old" examples of this, the lines contain text where the text is rendered at a different size in order to fit. The "new" versions do not do this, instead having content run-on/bleed across a page.

In the future (queasy.quokka) we will no longer be using column-count to implement multi-column content.

nyxer95 commented 8 years ago

We need to fix this sooner because we have multiple books in XML production. If we can do this as part of this milestone that would be preferable.

helenemccarron commented 8 years ago

I have found that we can control the svg max-width to stop them from extending past their container boundaries. I have added a fix for it in PR #1681. Please let me know if this has unintended consequences

InconceivableVizzini commented 8 years ago

InconceivableVizzini assigned helenemccarron and kerwinso and unassigned kerwinso and helenemccarron 2 minutes ago

kerwinso commented 8 years ago

Verified fix for Physics on textbook-dev. No regressions found. We'll need to discuss whether we want to apply this fix to other books as well.

image