openstax / oer.exports

Converter to various book formats (PDF, epub, mobi)
2 stars 0 forks source link

Table styling is incorrect #177

Closed edwoodward closed 10 years ago

edwoodward commented 10 years ago

In PDF at naginata.cnx.rice.edu:9090/content/col10023/latest/ screen shot 2014-02-10 at 9 21 37 am In Template: screen shot 2014-02-10 at 9 21 45 am

InconceivableVizzini commented 10 years ago

There is a markup issue with table captions in the history collection. The title text needs to be inside a span element with additional classes applied:

<span class="table-caption caption">Examples of Modern Prejudice</span>
edwoodward commented 10 years ago

Is this how have handled table titles in other books? I don't see it in the tagging legends.

InconceivableVizzini commented 10 years ago

Yes, and the styling for this is using a skeleton which is derived from a chain of books; history -> psychology->precalculus etc all are using the same selectors.

It may be that this markup is automatically generated during transforms and something there changed?

InconceivableVizzini commented 10 years ago

For Phil's benefit:

Old books used:

<caption xmlns="http://www.w3.org/1999/xhtml">
  <span class="cnx-gentext-caption cnx-gentext-t">Table </span>
  <span class="cnx-gentext-caption cnx-gentext-n">1.1. </span>
  <span class="table-caption caption">Examples of Modern Prejudice</span>
</caption>

and history is generating:

<caption xmlns="http://www.w3.org/1999/xhtml">
  <span class="cnx-gentext-caption cnx-gentext-t">Table </span>
  <span class="cnx-gentext-caption cnx-gentext-n">1.1. </span>
  Parliament Acts and Colonial Responses
</caption>
InconceivableVizzini commented 10 years ago

There is a problem with the cnxml in the history module. Previous books use

<caption> 

and this book is using

<title>
edwoodward commented 10 years ago

We will correct the markup.

edwoodward commented 10 years ago

This is fixed.