openstax / oer.exports

Converter to various book formats (PDF, epub, mobi)
2 stars 0 forks source link

Hide the <label> element in features #187

Closed philschatz closed 10 years ago

philschatz commented 10 years ago

<label> elements are needed in <note> elements so the fancy feature show up somehow (as a label) on content viewed somewhere other than in the PDF.

sosproduction commented 10 years ago

Assigned to History Milestone for now. I assigned to you Phil if you are writing script to replace? or if we need to include in tagging legend and turn off for PDF view we can do this... just assign back to me if there is tagging legend / CSS stuff to do (if in addition to script, or if no script work is needed)

philschatz commented 10 years ago

I think both things need to happen.

sosproduction commented 10 years ago

After updating collection and adding to each instance of notes, when DOM is generated, the label value is not being included in the XHTML. Phil is thinking the transform is not picking up the label. He is investigating. Bug is on hold for a little bit. Once Phil investigates and label is generating in PDF, I will try and target to turn-off.

philschatz commented 10 years ago

Turns out there is a bug in the docbook code from years ago. When a not has both a title and a label then they both get dropped from the PDF/HTML. I have a quick fix that should just drop the <label> (so no CSS needed)

sosproduction commented 10 years ago

No CSS needed...Assigning over to Phil pending docbook change and verification.

philschatz commented 10 years ago

This just in: actually, CSS is needed... in ccap-statistics.less of all places ; )

Still running regression tests on other books; will update this comment as they come in (a [x] means the test completed)

sosproduction commented 10 years ago

Assigning back to me for late breaking news :) This only goes to prove... all roads lead to statistics. :p