openstax / oer.exports

Converter to various book formats (PDF, epub, mobi)
1 stars 0 forks source link

Possible to Keep Table Header from Breaking with Following Content? #3852

Open openstaxalina opened 5 years ago

openstaxalina commented 5 years ago

What happened?

In at least one instance, a table header breaks with table content on the next page. While tables should be allowed to break over two pages, when only the header appears on the first page, it makes the table very difficult to read and looks like an error.

Reproducibility Details

Environment: content02.cnx.org (content production server)

Screenshots

Screenshot from content02 as linked above.

screen shot 2019-01-16 at 12 23 52 pm
brittany-johnson commented 5 years ago

As of 2/4/19, the content provided was updated and does not include the table markup in the given section. Do you think this was intentional? @openstaxalina @lwtchu screen shot 2019-02-04 at 12 30 25 pm screen shot 2019-02-04 at 12 30 46 pm

lwtchu commented 5 years ago

Looks like they changed it into a list to avoid the header from breaking. We can deprioritize it but it'd be nice for the future?

openstaxalina commented 5 years ago

Agree - let's avoid this change right before publishing, since it has been rendered unnecessary and making a change to tables might introduce significant testing/risk.

Moving this to the Books backlog.