openstaxalina commented 4 years ago

What happened?

We will be adding solutions into the Be Prepared notes that occur at the beginning of most non-intro modules.

The note is class be-prepared.

This will be the markup for the Be Prepared exercises:

<note class=”be-prepared”>
  <exercise>
    <problem>...</problem>
    <solution>...</solution>
  </exercise>
</note>

<note class=”be-prepared”>
  <exercise>
    <problem>...</problem>
    <solution>...</solution>
  </exercise>
</note>

...

Acceptance Criteria

(modified 12/17 based on team discussions)

We are matching the PDF to what was done in cnx-recipes as part of https://github.com/openstax/cnx-recipes/issues/1453:

[ ] Custom numbering of the Be Prepared features to match the Try Its: Each Be Prepared exercise will be in a separate <note> as the markup above shows. Each Be Prepared '' will be numbered using the same schema as the Try Its: 1.1, 1.2, etc. The exercise inside the note will NOT be numbered. (Note: Be Prepared and Try Its should be counted separately - they are different feature types. They just use the same numbering schema.)
[ ] The counter is continuous through the chapter. For example, module 1.2 might have Be Prepared 1.1 and Be Prepared 1.2; module 1.3 might have Be Prepared 1.3. Then the Be Prepared in chapter 2 start with Be Prepared 2.1.
[ ] In the PDF only, the Be Prepared exercises will have an icon to be provided by @lwtchu.
[ ] We've added collation instructions to the beginning of chs 1 & 2 in the collection linked below. Solutions need to collate to the beginning of the Answer Key - before the Try It answers - for each chapter. For example: Be Prepared 1.1 [answer] 1.2 [answer] etc.

brittany-johnson commented 4 years ago

The be prepared solutions are not collating in the answer key in the oer PDF and I can't move them since it's not a recipe. I think we may need some collation instructions.

openstaxalina commented 4 years ago

@marcjeannott could you please add the following collation instruction in chs. 1 & 2 on easyvm5? <?cnx.answers class="be-prepared"?>

Please double-check that that is the exact class that is on the Be Prepared note. If there are any other classes on the note, those should also go in the collation instructions.

lwtchu commented 4 years ago

@helenemccarron here's the icon https://drive.google.com/open?id=1n-P991FxxT117_jd_m0gSe0qjMNn_mfN let me know if you need adjustments cause i dont have the original files 😬

Meet Google Drive – One place for all your files
Google Drive is a free way to keep your files backed up and easy to reach from any phone, tablet, or computer. Start with 15GB of Google storage – free.

openstaxalina commented 4 years ago

The test content -- chapters 1 & 2 only per dev request -- is here: https://easyvm5.cnx.org/contents/MDaDgCT2 (UUID 30368380-24f6-4c51-9c04-7c802622b040 on easyvm5)

OpenStax CNX

brittany-johnson commented 4 years ago

lwtchu commented 4 years ago

@brittany-johnson looks like u need to download a font called roboto slab.

also i might be partially to blame since i just gave the icon and didn't write it out. were we going to style these like the try its? cc @helenemccarron

brittany-johnson commented 4 years ago

Downloaded the roboto slab font!

brittany-johnson commented 4 years ago

Note for @omehes: When this issue is ready for testing, please also download Roboto Slab font to your system.

omehes commented 4 years ago

@brittany-johnson from the note above I assume that this is not testable yet, right?

helenemccarron commented 4 years ago

I believe downloading the font will not be necessary when generating the PDF on the server :D And no, @omehes I am currently trying to solve the last snag with this, we will let you know as soon as it's ready.

brittany-johnson commented 4 years ago

The "Be Prepared" notes should be styled like the "Try It" notes and the numbering of the "Be Prepared" notes should behave as described above under the acceptance criteria. The link to test content is above as well.

There is also a known issue with "Be Prepared" 1.1. In the current test content, the link at the bottom of the note is not displaying correctly and is causing the note to become unaligned. Once this is fixed in the content, it will display properly.

Be Prepared note 1.1 that is displaying incorrectly Screen Shot 2020-01-16 at 12 16 17 PM

Be Prepared note that should be styled like the Try It note Screen Shot 2020-01-16 at 12 16 07 PM

Example of Try It note Screen Shot 2020-01-16 at 12 25 52 PM

lwtchu commented 4 years ago

BELLISSIMO @brittany-johnson

omehes commented 4 years ago

verified "be prepared::" fix. the numbering after "be prepared::x.y is not of grey colour but blue. As discussed with @brittany-johnson, the colour should be grey.

the rest of fix is correct

beprep_colour