search

openstax / oer.exports

Converter to various book formats (PDF, epub, mobi)
2 stars 0 forks source link

Entrepreneurship - Long URL trails into margin #3995

Open mwest-WWprod opened 4 years ago

mwest-WWprod commented 4 years ago

Ch. 7 Suggested Resources - content01.cnx.org/content/col10117/1.3 Entrepreneurship

Long URL trails into the margin of the PDF file. If this can be addressed by markup let us know, it's our understanding currently that inducing a break is controlled by the platform.

Resource_Link_Eship

openstaxalina commented 4 years ago

@mwest-WWprod letting you know we received this and will provide feedback later this week. Thanks!

openstaxalina commented 4 years ago

We will try a technical solution: “word-wrap: break-word”, which seems to be supported by Prince. @helenemccarron may link to more information.

mwest-WWprod commented 4 years ago

@openstaxalina @helenemccarron FYI there is another instance of this at the end of Chapter 2 Module 3 (content01.cnx.org/content/col10104/1.6) in a footnote

image

openstaxalina commented 4 years ago

@theresamasciale could you please migrate the module (just one module) with the long URL to the following collection: https://easyvm5.cnx.org/contents/C2WpSVax.

Please un-assign yourself and apply the label "test.content.confirmed" when this is complete!

theresamasciale commented 4 years ago

Chapter 7 has been migrated https://easyvm5.cnx.org/contents/C2WpSVax

OpenStax CNX
Stackblocks commented 4 years ago

Currently investigating the use of https://www.princexml.com/doc/11/properties/overflow-wrap/ as a solution for oer.exports since word-wrap declines to break up the long string in the middle of the URL and word-break gets a little aggressive.

Work is being done on the branch "issue-3995"

Stackblocks commented 4 years ago

TO BE REVISITED:

omehes commented 4 years ago

@helenemccarron Verified on latest build and book version 5.12. Both url are fixed: https://easyvm5.cnx.org/contents/04BRDmFF@5.12:1ykNQm79@1/1-1-Introduction

entr-1ok

entr-2ok

OpenStax CNX
openstaxalina commented 4 years ago

The URL adjustment pushed the resources too far left on the page -- this can be seen on the screenshot above where "This" (in two places) is further left on the page than the Suggested Resources icon or the section header.

I believe that we should revert this change and only handle long URLs in the baked PDFs. If there are long URLs in oer.exports PDFs, we can find them as part of the publication checklist and fix them manually in Adobe.

Stackblocks commented 4 years ago

@openstaxalina I think the over-left alignment of the "This"es is a separate issue, but we may need Brittany J or Helene to confirm.

There is a text-indent for the hanging-indent that, when disabled, causes things to get into block alignment so that may need to be adjusted in a separate fix to alter the alignment there.

enabled

image

disabled

image

openstaxalina commented 4 years ago

@Stackblocks thank you for pointing me to that!

I know that we previously fixed an over-left issue (although it hadn't been quite as far over-left) via this card: https://github.com/openstax/oer.exports/issues/3975.

I am not sure if that fix got disabled or perhaps something else happened.

We do note that the PDF generated before today's code rollout (which included this card) did not have the over-left problem. (By the way, to alleviate possible concern: we are manually fixing the URLs on the PDF with the older code to facilitate publishing the book, which arguably we should/could have done to begin with!)

Stackblocks commented 4 years ago

It looks like that fix added in the very same negative text-indent from above and it was tested/confirmed for that issue, so I wonder what could have happened.

At the very least we know it didn't disappear, haha!

I'll try and turn up the cause of the over-left issue and if needs be we can disable this / whatever else.

openstaxalina commented 4 years ago

Okay - from my perspective we could also revert the PR associated with this issue (https://github.com/openstax/oer.exports/pull/4011) because I understand it was a one-off anyway and that we want a more sustainable fix in baked PDF. Thoughts?

Stackblocks commented 4 years ago

My concern is that this may be an issue of correlation w/o causation and that disabling this issue will re-break the overflowing links leading the hand-reworking of all of those while also not resolving the overly-left text.

Looking at the contents of that PR, it doesn't contain anything that adjusts alignment outside of allowing text to break mid-word if it exceeds certain bounds.

Do we know what else went out in this oer.exports release alongside the two PRs discussed so far?

Enabled

image

Disabled

image

Changes in PR#4011

image