openstax / oer.exports

Converter to various book formats (PDF, epub, mobi)
2 stars 0 forks source link

Entrepreneurship - Centered text class not enabled #4013

Open openstaxalina opened 4 years ago

openstaxalina commented 4 years ago

@mwest-WWprod commented on Fri Nov 22 2019

Chapter 3 (may be Global) https://legacy-content01.cnx.org/content/col10091/1.2 Entrepreneurship

Centered text class appears to not be enabled. We have an instance in Chapter 3 where a line of text is set with this class per tagging legend, and the output appears as seen below.

Markup centered text_Eship

Output centered text_Eship Output


@openstaxalina commented on Fri Nov 22 2019

@theresamasciale, could you please double-check the markup on this? The CM team may have some feedback on this, too.

If this cannot be resolved in markup, we will investigate on the dev side.


@theresamasciale commented on Fri Nov 22 2019

I looked at this module in Atom and it does have the centered text class on the section. Here is the markup:

<section id="fs-idm200507520" class="centered-text"> <para id="fs-idm225313808">personal values → personal mission statement → entrepreneurial mission statement</para> </section>

It's also centered fine in webview, so this is just a PDF issue.


@openstaxalina commented on Sun Dec 08 2019

@theresamasciale could you please migrate the module (just one module) with the centered text to the following collection: https://easyvm5.cnx.org/contents/C2WpSVax.

Please un-assign yourself and apply the label "test.content.confirmed" when this is complete!

OpenStax CNX

@brittweinstein commented on Mon Dec 09 2019

@theresamasciale please discuss with CMs--it is possible the centering tag should be on the para instead.

openstaxalina commented 4 years ago

@theresamasciale please look at this after you have migrated the content.

theresamasciale commented 4 years ago

removed the mathml and put it in a regular para tag with a centered-text class. This centers properly in webview but it's left aligned in the pdf

Screen Shot 2019-12-13 at 11.51.31 AM.png

openstaxalina commented 4 years ago

To facilitate delivering the book for final QA, Theresa and I decided to manually center the text on the PDF. Thus, markup is still correct and PDF display will be fixed by devs.

lwtchu commented 4 years ago

Theresa manually centered it.

@theresamasciale move issue to oer.exports OR re-open the old card. whichever works better.

theresamasciale commented 4 years ago

Fixed tags so that the text is NOT written in mathml. Then, I moved the "centered-text" tag to be in the tag, not a section. This centers it in webview, but not in the PDF.

Transfering issue to oer-exports.

openstaxalina commented 4 years ago

We are manually centering the text in these two places for the purposes of publishing the PDF.