openstax / oer.exports

Converter to various book formats (PDF, epub, mobi)

2 stars 0 forks source link

Table Heading is not aligned correctly #4016

Closed clteam18 closed 4 years ago

clteam18 commented 4 years ago

Book(s): College Success
URL/Server: PDF
Location (page number, chapter/section): Chapter 03/m10097 - PDF page 19
Suggested nearby searchable text: personal assessment of their time are often surprised

Screenshots

Additional notes

Table headings are not aligned correctly for particular table only. Two headings are aligned as left and 3rd heading is aligned as right. This table is newly added based on feedback.

openstaxalina commented 4 years ago

We will investigate the markup first. cc @lwtchu

lwtchu commented 4 years ago

@openstaxalina the mark up is as follows

<row><entry align="center">Activity</entry><entry align="center">Estimated Time</entry><entry align="center">Actual Time</entry></row>

there's a bug with the template. the tables should be using alignment from the content.

openstaxalina commented 4 years ago

Thank you! @lwtchu could Colby (or possibly someone while he is out) make sure this content is on easyvm5, in this collection? https://easyvm5.cnx.org/contents/h2TUSN8V

Once this is confirmed, please add the label test.content.confirmed to this issue and remove any assignees.

OpenStax CNX

lwtchu commented 4 years ago

@openstaxalina when do you need this by? i think it's under colby's account on easyvm5

openstaxalina commented 4 years ago

@lwtchu Can he does this when he is back Monday morning? Devs might start working on this next week.

yblock commented 4 years ago

Added test content table to module as requested.

openstaxalina commented 4 years ago

Located in this module: https://easyvm5.cnx.org/contents/h2TUSN8V:WGrTvQRO

Search for nearby text: personal assessment of their time are often surprised

OpenStax CNX

brittany-johnson commented 4 years ago

openstaxalina commented 4 years ago

@brittany-johnson in the screenshot, the titles seem to be aligned left, although the markup from @lwtchu's comment has an attribute for center alignment. Are we able to do the center alignment (or is there something wrong with the test data, perhaps)?

brittany-johnson commented 4 years ago

@openstaxalina This is my mistake. I was focusing on the far-right column and how it was not aligned like the others. I'll fix this!

brittany-johnson commented 4 years ago

openstaxalina commented 4 years ago

thank you @brittany-johnson ! cc @lwtchu

omehes commented 4 years ago

verified. fixed. Actual time and other table headings are centre aligned on all pges.

cosu_tab

openstaxalina commented 4 years ago

[content not available on staging for testing]

yblock commented 4 years ago

verified in staging

openstaxalina commented 4 years ago

verified on content03: Screen Shot 2020-02-12 at 4 41 07 PM