openstax / oer.exports

Converter to various book formats (PDF, epub, mobi)
2 stars 0 forks source link

Psych2e - Table numbers breaking from tables #4035

Closed mwest-WWprod closed 4 years ago

mwest-WWprod commented 4 years ago

content02 Ch. 6 but likely GLOBAL (https://legacy-content02.cnx.org/content/col10034/1.3)

In Ch. 6 there is an instance of a table number breaking across a page, separated from its table.

Psych table number breaking

openstaxalina commented 4 years ago

@theresamasciale could you try adjusting the markup here to be a top-titled table, and see if this and/or issue #4034 are fixed?

I looked at the markup and I don't think the tables are being properly marked up as top-titled: Screen Shot 2020-02-12 at 4 32 45 PM

@lwtchu two other things we should discuss:

brittweinstein commented 4 years ago

@openstaxalina will confirm that this is resolved.

openstaxalina commented 4 years ago

This should be resolved with proper top-titled table markup.

We should retest this once #4038 and #4034 are fixed. I made a note and will follow up on this.

brittweinstein commented 4 years ago

@omehes this should be ready to test.

omehes commented 4 years ago

@theresamasciale @openstaxalina

Verified on e.e

4038 and 4034 are fixed But this issue (4035) is still present. Discussed with @brittweinstein Not fixed

brittweinstein commented 4 years ago

@Stackblocks will review BrittanyJ's PR on page breaks to see how it relates in oer.exports.

omehes commented 4 years ago

@Stackblocks This does not need further verification?

Stackblocks commented 4 years ago

@omehes There's no way to verify it with the existing data. In a PDF built with the test data linked in the issue Table 6.2 appears in the middle of a page instead of at a point where this break was an issue, so we are unable to confirm with 100% veracity. The issue was reported using a set of the data from a content development instance, and that data has progressed from where it was when the issue was reported so we can't directly recreate it.

image

omehes commented 4 years ago

OK. Thanks