openstax / oer.exports

Converter to various book formats (PDF, epub, mobi)
2 stars 0 forks source link

Tables in Psych 2e Lost Proper Top-Title Styling #4038

Closed theresamasciale closed 4 years ago

theresamasciale commented 4 years ago

What happened?

When reviewing the xml for the delivered chapter 6 in Psych 2e, we noticed the tables were not formatted with the class "top-titled" as they should be. Using the tagging legend, I formatted the tables to be "top-titled" (see markup below). While this brought the title up out of the caption area, it did not perform the way it should when we tested this new style prior. Titles are inside a cell and black, when they should be floating just above the table with red text. Please see previous testing issue for reference: https://github.com/openstax/oer.exports/issues/3914

Reproducibility Details

Environment:

Screenshots

Screen Shot 2020-02-14 at 3.20.47 PM.png

Additional notes

helenemccarron commented 4 years ago

The top titled tables were not supported in non business books, I added a quick fix for psychology only. We will need to duplicate this for any other books that require it. 2020-02-18_13-05-26

brittweinstein commented 4 years ago

@omehes this is ready for testing :)

omehes commented 4 years ago

tested on e.e all tables in chapter 6.3 looks good in pdf

tables63