openstax / openstax-cms

The OpenStax CMS, built using Wagtail on top of Django.
https://openstax.org
GNU Affero General Public License v3.0
100 stars 15 forks source link

New RootPage and FlexPage types to support new homepage (and more) #1567

Closed mwvolo closed 4 months ago

TomWoodward commented 4 months ago

also, every link we have should always have link_text, link_url, and link_aria_label, should we make a composable block so that we don't always have to have all three urls on everything? looking at the fields on the hero for primary/secondary cta, it seems like it might help

mwvolo commented 4 months ago

@TomWoodward should any of those be required? Like the aria_label?

TomWoodward commented 4 months ago

aria-label for links can be optional, its just commonly needed when like 7 links on the page's text are "read more"

TomWoodward commented 4 months ago

lets not forget to remove the image from the layout snippet, we didn't end up using it