openstax / poet

VSCode Extension to edit OpenStax books
https://gitpod.io/#https://github.com/openstax/poet
GNU Affero General Public License v3.0
2 stars 5 forks source link

2105 resource count quarx #169

Closed TylerZeroMaster closed 1 year ago

TylerZeroMaster commented 1 year ago

Summary

Replaces excessive looping with a shared lists in the bundle for duplicate UUID and resource checks. These lists are automatically updated by quarx when the underlying models change.

Fixes openstax/ce#2105

Duplicate Resources are Reported Correctly

GIVEN

GIVEN

Duplicate UUIDs are Reported Correctly

GIVEN

GIVEN

omehes commented 1 year ago

verified on ext dev-169 - various scenarious were tested - discussed scenarios with Tyler looks good

one bug found: https://github.com/openstax/ce/issues/2110 - also discussed

omehes commented 1 year ago

verified on 6.5.2 - looks good