openstax / rex-web

Unified Reading EXperience
https://rex-web.herokuapp.com/
GNU Affero General Public License v3.0
15 stars 1 forks source link

It's possible to make multiple highlights over the same search highlight #1572

Closed firadecki closed 1 year ago

firadecki commented 2 years ago

Description

We are able to make multiple highlights over the same search highlight without any errors and MH shows all those multiple highlight entries.

To Reproduce Steps to reproduce the behavior are:

  1. https://openstax.org/books/college-physics/pages/2-introduction-to-one-dimensional-kinematics
  2. Search for velocity
  3. Highlight over the same search result multiple times Issue: We are able to make multiple highlights over the same search highlight without any errors and MH shows all those multiple highlight entries.

Expected behavior We are not able to make multiple highlights over the same search highlight

Screenshots

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context

Acceptance Tests

Additional acceptance tests that are required by this bug fix.

User is not able to make multiple highlights over the same search highlight Highlighting

GIVEN Login {base_url}/books/college-physics/pages/2-introduction-to-one-dimensional-kinematics WHEN Search for velocity AND Highlight over the search result AND Try to highlight over the same search result again THEN something

Approvals

1A-PRE DESIGN

1C-DESIGN

2B-REVIEW

Process

Work Management for Unified

RoyEJohnson commented 1 year ago

I can't reproduce the problem now (Chrome, Mac desktop). Is it fixed?

Malar-Natarajan commented 1 year ago

@ewaforman I think this was fixed sometime back. Can you please retest and close if this works fine

ewaforman commented 1 year ago

Works fine.