search

openstax / webview

Connexions web site
http://cnx.org
GNU Affero General Public License v3.0
12 stars 8 forks source link

Upgrade from Node 6.9.x to 10.15.x #2250

Closed mmulich closed 5 years ago

mmulich commented 5 years ago

This moves from our custom container to using the official node built container. Last time I tried upgrading it failed, so something has changed between now and then that has allowed it to build.

I'm not exactly sure how to test this; so please use scrutiny while reviewing.

mmulich commented 5 years ago

I've assigned to @helenemccarron for merge acceptance of this work.

helenemccarron commented 5 years ago

I second Thomas, it looks good but Webview should be tested to ensure nothing odd is happening after the update.