openstax / webview

Connexions web site
http://cnx.org
GNU Affero General Public License v3.0
12 stars 8 forks source link

APUSH: Move Exercise Text onto the Line with Its Number #2266

Closed openstaxalina closed 5 years ago

openstaxalina commented 5 years ago

@openstaxalina commented on Fri Jun 28 2019

Scenario

The text of any exercise should be in line with its number, not on the line below.

For example, in this module... APUSHExerciseTxtSameLine

Environment:

Test Plan

Acceptance Criteria

-Exercise text appears on the same line as the exercise number.


@tomjw64 commented on Thu Jul 11 2019

This is a styling issue, not a recipe issue. Reassigning to @brittany-johnson

brittany-johnson commented 5 years ago

Screen Shot 2019-07-15 at 3 21 10 PM

Stackblocks commented 5 years ago

for review with staging APUSH collection from the initial comment.

Stackblocks commented 5 years ago

image.png

openstaxalina commented 5 years ago

It looks like this was fixed! What do you think, Alan? Screenshot from: https://staging.cnx.org/contents/KC8KeLYF@2.1:dSSl_YvL@2/1-17-%E2%9C%92%EF%B8%8F-Watercolors-of-Algonquian-Peoples-in-North-Carolina-1585 Screen Shot 2019-07-25 at 4.13.53 PM.png

OpenStax CNX
Stackblocks commented 5 years ago

@openstaxalina It looks like questions that are importing correctly (read: not MISSING EXERCISE display correctly, while the missing ones still line break.

Since MISSING EXERCISE is not the desired end state, does this meet our definition of done?

image

openstaxalina commented 5 years ago

@Stackblocks good point. I think that the production teams or I can retest this on content05, where the exercises should import properly. Then we could (hopefully) close this issue. Would that plan work?

openstaxalina commented 5 years ago

Unfortunately it looks like assessments pulled in from Exercises still have the line break: Screen Shot 2019-08-01 at 1 47 05 PM

link: https://content05.cnx.org/contents/CmIfJ6vh@30.1:CtEXAR4u@12/1-3-%F0%9F%94%8E-Native-People

I am going to move this into o.o so we could take a look at this. It may be a case of not having the proper test content on the proper servers. I will note to park this on Monday. cc @Stackblocks @brittany-johnson

OpenStax CNX
Stackblocks commented 5 years ago

Another point there is that the Review Questions are behaving correctly, so it may be limited to Review Questions

openstaxalina commented 5 years ago

Review Questions and Test Prep for AP Courses are the only two exercise types in the title that pull in from Exercises - I think pulling in from Exercises seems to cause/be related to the display problem.

openstaxalina commented 5 years ago

Module with test content: https://staging.cnx.org/contents/KC8KeLYF:w01bi3xv

Need to determine what instance of Exercises easyvm5 points to.

Might need a CM to encode 2-3 exercises with the relevant nicknames on THAT instance of Exercises.

OpenStax CNX
openstaxalina commented 5 years ago

@dtwilliamson confirmed that easyvm5 is pointing to production exercises.

openstaxalina commented 5 years ago

not fixing now; webview is not the destination platform for APUSH. The exercises are already displaying without the line break in Tutor.