openstenoproject / plover

Open source stenotype engine
http://opensteno.org/plover
GNU General Public License v2.0
2.33k stars 281 forks source link

With NumLock enabled, selecting whole words at a time breaks (i.e. {#Control(Shift(Left))} and {#Control(Shift(Right))}) #1566

Open aesulus opened 1 year ago

aesulus commented 1 year ago

Describe the bug

Between plover-4.0.0.dev10 and plover-4.0.0.dev12, {#Control(Shift(Left))} and {#Control(Shift(Right))} functionality seems to have been broken (I have not checked plover-4.0.0.dev11).

To Reproduce

Steps to reproduce the behavior:

  1. Define strokes for {#Control(Shift(Left))} and {#Control(Shift(Right))}
  2. With NumLock enabled, use those strokes to attempt to select text
  3. Cursor is moved across whole words but text is not selected

Expected behavior {#Control(Shift(Left))} and {#Control(Shift(Right))} moves cursor across whole words while selecting text.

Screenshots Testing site used: https://w3c.github.io/uievents/tools/key-event-viewer.html Keystroke output in plover-4.0.0.dev10 (expected) Screenshot 2022-10-11 at 13-21-48 Keyboard Event Viewer

Keystroke output in plover-4.0.0.dev12 (broken) Screenshot 2022-10-11 at 13-21-37 Keyboard Event Viewer

Operating system

aerickt commented 1 year ago

I'm not sure if I'm understanding the screenshots, but it seems that NumLock is enabled on both tests. Sometimes having NumLock on can interfere with Plover (see here: https://github.com/openstenoproject/plover/issues/1531). I'd suggest trying the strokes after turning NumLock off.

aesulus commented 1 year ago

Re-ran tests with NumLock off. Output between dev10 and dev12 are now identical.

Screenshot 2022-10-12 at 13-36-26 Keyboard Event Viewer

aesulus commented 1 year ago

updated title and description to include NumLock

phuertay commented 2 weeks ago

I can confirm this issue still exists in Plover 4.0.0rc2+6.g53c416f, in Windows 11. I'm getting NumpadLeft instead of Left (the arrow).