search

openstf / STFService.apk

Monitor and perform various actions on your Android device. Not meant for actual user devices.
Other
242 stars 207 forks source link

Implement set and get Bluetooth status. #20

Closed JeannedArk closed 6 years ago

JeannedArk commented 6 years ago

The adaptation for the stf server side, will follow.

sorccu commented 6 years ago

Sorry I’ve been super busy.

I see some minor differences in formatting. For example sometimes there’s a space after before parentheses and sometimes not. Would be nice to use same formatting everywhere.

So currently if Bluetooth is not supported, it’ll just return false? I wonder if it would be useful to have a third state, e.g, unknown, unsupported or not available.

JeannedArk commented 6 years ago

Hi, no worries. I haven been also busy lately so this is why my answer comes that late.

Oh, sorry for the formatting mistakes.

Yes, it does. It is probably useful for some people, but then you have to adjust also the server side and display these cases correctly. Also then you could do that for WiFi etc. too, as e.g. "isWifiEnabled()" can throw a NullPointerException. Therefore, I have only fixed the formatting mistakes and would propose to do the other suggestions in a different pull request.