search

openstf / STFService.apk

Monitor and perform various actions on your Android device. Not meant for actual user devices.
Other
242 stars 207 forks source link

add screenshot function for the agent #7

Closed xinyu0601 closed 7 years ago

xinyu0601 commented 7 years ago

Add screenshot support. The code have been tested in nearly 50 phones which has includes phones that are not support by minicap before.

I also try to use libturbojpeg to make compress faster, but failed any way maybe you can helps ^_^ @sorccu In real devices one screenshot takes about 300~500ms. While in simulator(eg. iToolsVM, bluestacks) only take 60ms.

Thanks for you great job any way.

sorccu commented 7 years ago

Interesting. It does add a bit of complexity to STF since it would have to handle this alternative way as well. Ideally the output would be compatible with minicap instead of going through zmq. Perhaps it could still be part of the same APK, but runnable as a command like app like the Agent.

By the way do you have a list of devices that don't work?

codeskyblue commented 7 years ago
codeskyblue commented 7 years ago

Can it be merged?

sorccu commented 7 years ago

I've created issues for those devices in openstf/stf#484 and openstf/stf#485, please post the errors you are seeing. Also please include the output of adb shell getprop (remove private information like IP addresses). Also, if possible, run adb pull /system/lib/libgui.so and attach it to the issue of that device.

sorccu commented 7 years ago

It could be merged but it would also require changes to STF, and if STF has to support many different formats, it'll make it more difficult to improve it later. Do you think you could use https://developer.android.com/reference/android/net/LocalServerSocket.html and make it output the frames in the same format as minicap? That would make it a lot easier to use and require only relatively few changes in STF.

sorccu commented 7 years ago

The minicap format is very simple, it's described here: https://github.com/openstf/minicap#usage

codeskyblue commented 7 years ago

the two device only reported not supported stf. have to check again. BTW: we still donot know are you interested this pr or not.

codeskyblue commented 7 years ago

Because the speed without turbojpeg is very slow. 400ms per screenshot. Is it necessary to start a socket server?

sorccu commented 7 years ago

If you make it compatible with minicap, it'll be easier to improve performance later on as a separate unit (perhaps with JNI & libjpeg-turbo)

codeskyblue commented 7 years ago

We have tried many days on use JNI & libjpeg-turbo to improve the encode performance. But failed any way. It is not easier for us for we are not very good at C. Really need your help on this part. And we can do the rest.

codeskyblue commented 7 years ago

Also I notice that screenshot on STF use command minicap -s -P ... > /data/local/tmp/screen_xxx.jpg and pull it from the device, It would be better to use this local java method.

sorccu commented 7 years ago

I know it's more work for you to make it behave like minicap, but otherwise it's more work for me, and I just don't have that much time. If you can make it work like minicap, then we have a real chance at getting it integrated with stf fairly quickly.

On Fri, 25 Nov 2016 at 0:04 shengxiang notifications@github.com wrote:

Also I notice that screenshot on STF use command minicap -s -P ... > /data/local/tmp/screen_xxx.jpg and pull it from the device, It would be better to use this local java method.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openstf/STFService.apk/pull/7#issuecomment-262795868, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB-_SiUbDIU8ccFBmfN5OUJHLJdQQpPks5rBaeMgaJpZM4K7Nj8 .

codeskyblue commented 7 years ago

sure we can do this part.