Support single touch event files

konradweiss commented 7 years ago

Some emulators do not have files supporting multitouch but single touch to emulate events. To support it the scoring was adapted to consider input files having that capability but still giving moultitouch the preference. Most important are two changes:

State contains the event code attributes used to send the touch events depending on the property of the device.
The function set_abs_configuration sets some information such as screen resolution and event code used for touches.

sorccu commented 7 years ago

Hmm, it seems to just patch the coordinate events, I don't think we should be sending the other events (like syn_mt_report) at all. Could cause issues if left like that. On Wed, Mar 29, 2017 at 5:24 Konrad Weiss notifications@github.com wrote:

Some emulators do not have files supporting multitouch but single touch to emulate events. To support it the scoring was adapted to consider input files having that capability but still giving moultitouch the preference. Most important are two changes:

State contains the event code attributes used to send the touch events depending on the property of the device.

The function set_abs_configuration sets some information such as screen resolution and event code used for touches.

You can view, comment on, or merge this pull request online at:

https://github.com/openstf/minitouch/pull/15 Commit Summary

Enable scoring for single touch devices such that certain emulators do not fail. Single touch devices get outscored by multitouch devices.

Adding event code to state of devices, a function to configure the movement event code and the screensize.

Fixes right scoring for multitouch devices

File Changes

M jni/minitouch/minitouch.c https://github.com/openstf/minitouch/pull/15/files#diff-0 (56)

Patch Links:

https://github.com/openstf/minitouch/pull/15.patch

https://github.com/openstf/minitouch/pull/15.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openstf/minitouch/pull/15, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB-_QaGxut1EpmAQ8zhuPQGVa3_kOtCks5rqWxkgaJpZM4MsJZw .

konradweiss commented 7 years ago

Yes, I send the right event depending on the capabilities of the device. I will do a test if I can leave that command out for single touch devices and will do a new commit.

sorccu commented 7 years ago

I think I would kind of prefer if the events were not set dynamically, instead, the state would have a flag for the type (single/multi) and single touch would dispatch to a separate single-touch only method. That way it would be clearer what it does. There may be a need to add other methods later as well (e.g. stylus input which is a separate event device on some devices. On Wed, Mar 29, 2017 at 16:21 Konrad Weiss notifications@github.com wrote:

Yes, I send the right event depending on the capabilities of the device. I will do a test if I can leave that command out for single touch devices and will do a new commit.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/openstf/minitouch/pull/15#issuecomment-290005293, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB-_ZJqWQblRiF7bSoKO28gYAXJBF4sks5rqgaHgaJpZM4MsJZw .

konradweiss commented 7 years ago

I could define a is_multitouch in state and depending on that perform the touch with the ABS_MTPOSITION... or ABS_... events, if that is the the way you prefer it and better structures the project for your future extension?

konradweiss commented 7 years ago

Sorry, I was busy with a different project in the last month. I tried to interpret your suggestions in the correct manner and created different functions for single and multi touch events to remove the dynamically set event codes. I also removed syn_mt_report from the single_touch methods. As I don't know exactly which events are necessary, I did not dare to remove every event containing MT in the single touch methods. So if you want to remove more of them, tell me or just do it after pulling in case you accept the pull request.

Regards, Konrad

sorccu commented 7 years ago

The best way to see which events are required would be to use an OTG cable to connect a mouse to a device, and then check what events it sends with getevent.

On Mon, May 8, 2017 at 19:10 Konrad Weiss notifications@github.com wrote:

Sorry, I was busy with a different project in the last month. I tried to interpret your suggestions in the correct manner and created different functions for single and multi touch events to remove the dynamically set event codes. I also removed syn_mt_report from the single_touch methods. As I don't know exactly which events are necessary, I did not dare to remove every event containing MT in the single touch methods. So if you want to remove more of them, tell me or just do it after pulling in case you accept the pull request.

Regards, Konrad

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/openstf/minitouch/pull/15#issuecomment-299827544, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB-_ZrFSxDLLAJ2iCpe9HWgxye61oJMks5r3uoYgaJpZM4MsJZw .