search

openstream / Magento2_German_LocalePack_de_CH

Sprachpaket Deutsch (Schweiz) für Magento 2 Community Edition
Open Software License 3.0
3 stars 2 forks source link

Magento 2 prices are shown only with one digit after decimal #10

Open involatus opened 3 years ago

involatus commented 3 years ago

The language Pack changes how the prices are shown on the product page and in the checkout process. The prices are only shown with one digit after the decimal. In the gridview the prices are correctly shown with two digits after decimal. See screenshot here: https://ibb.co/rkYyG9x

Please contact me to give you a live preview.

nickw108 commented 3 years ago

Thanks for the pointer. This is only a fork from de_DE, not sure if they have the same problem. Let me pull the changes from upstream, then you can test again.

nickw108 commented 3 years ago

If synced from upstream and pushed the changes. May I ask you to check again now?

involatus commented 3 years ago

I updated the package. I now have openstream/mage2-locale-de-ch | Language | 1.63.0 | Openstream installed. Sadly the prices are still displayed with only one digit. With a clean installation and the Ultimo theme this didn't happen.

nickw108 commented 3 years ago

We had the same issue with a client project and installed https://github.com/lillik/magento2-price-decimal to "fix" the problem. Are you sure that the reason is this de_CH module?

involatus commented 3 years ago

The only other Extensions installed is cleverreach and the utlimo theme. Nevertheless I could fix it as well with this additional extension. Not the prettiest way but it worked. Thank you for your help.

nickw108 commented 3 years ago

I asked my colleague to look into it, but I can't promise anything. If anyone else reads this and wants to debug this further and create a pull request, feel free to do so.

pixelhed commented 3 years ago

@involatus the problem @nickw108 was referring to was with centos, do you use it?

involatus commented 3 years ago

@involatus the problem @nickw108 was referring to was with centos, do you use it?

Yes correct, installed version is CentOS Linux 7 (Core)

nickw108 commented 3 years ago

More details here https://github.com/magento/magento2/issues/12090.

pixelhed commented 3 years ago

@involatus just install https://github.com/lillik/magento2-price-decimal it will fix the problem with Centos