search

openstreetmap-polska / openaedmap-frontend

Map which shows locations of defibrillators (AEDs) and allows adding new ones.
https://OpenAEDMap.org
MIT License
29 stars 18 forks source link

Navbar, card, other UI adjustments #213

Open Ancymonek opened 7 months ago

Ancymonek commented 7 months ago

Navbar, card, other UI adjustments

Not tested as logged in user (cannot set up)

starsep commented 7 months ago

Language picker is cut off for longer language names

Actually it is already cut off. image image image

After PR it happens for even shorter language names

Ancymonek commented 7 months ago

I was thinking about it - some solution is that we can display only codes of languages in the navbar and full name + code when navbar is expanded: obraz

But there still be issue for lang code like Zh-Hans..

starsep commented 7 months ago

I was thinking about it - some solution is that we can display only codes of languages in the navbar and full name + code when navbar is expanded:

I think it's a good idea.

Regarding Chinese (both tradition and simplified) I think it should be possible to fit in two characters. Current names have 4 characters:

    "zh-Hans": { nativeName: "简体中文" },
    "zh-Hant": { nativeName: "繁体中文" },

What do you think? @LaoshuBaby @Supaplextw @s8321414

s8321414 commented 7 months ago

I was thinking about it - some solution is that we can display only codes of languages in the navbar and full name + code when navbar is expanded:

I think it's a good idea.

Regarding Chinese (both tradition and simplified) I think it should be possible to fit in two characters. Current names have 4 characters:

    "zh-Hans": { nativeName: "简体中文" },
    "zh-Hant": { nativeName: "繁体中文" },

What do you think? @LaoshuBaby @Supaplextw @s8321414

It should be "简体中文" for zh-Hans and "繁體中文" for zh-Hant I think.

LaoshuBaby commented 7 months ago

I was thinking about it - some solution is that we can display only codes of languages in the navbar and full name + code when navbar is expanded:

I think it's a good idea.

Regarding Chinese (both tradition and simplified) I think it should be possible to fit in two characters. Current names have 4 characters:

I have no problem with using language codes to represent Simplified and Traditional Chinese, it depends on the technical choices of the project. (Because name:zh-Hans and name:zh-Hant are used in OSM data)