search

openstreetmap-polska / openaedmap-frontend

Map which shows locations of defibrillators (AEDs) and allows adding new ones.
https://OpenAEDMap.org
MIT License
31 stars 18 forks source link

Add buttons to open Google Maps and OSM map navigation #49

Closed caspg closed 2 years ago

caspg commented 2 years ago

There should be buttons that open Google Maps and OSM map navigation. It should be visible in the popup details.

Similarly to https://dopomoha.pl/en/#map=4.26/53.38/20.81

Screenshot 2022-09-20 at 08 11 55
Vinayakkamble07 commented 2 years ago

Hi, can I try this? I'm a beginner and would like your help to fix this issue.

ttomasz commented 2 years ago

Go ahead. Relevant part of code from dopomoha.pl to provide an example https://github.com/openstreetmap-polska/ua-2022-map/blob/main/templates/map.js#L435

Vinayakkamble07 commented 2 years ago

Will try it ASAP!!!

starsep commented 2 years ago

@Vinayakkamble07 How it's going :)? Feel free to make a draft pull request even if it's not ready, perhaps I can help.

Vinayakkamble07 commented 2 years ago

@starsep would love your help on this .Finding it difficult to solve this issue.

starsep commented 2 years ago

It's hard to help without some details. Are you able to run project locally? Do you have experience with HTML/CSS/React/JavaScript?

Those buttons should be in AED popup details, somewhere on the bottom. Example link: https://openaedmap.org/#map=17/51.158873/21.649783&node_id=9437937877 Footer is defined here: https://github.com/openstreetmap-polska/openaedmap-frontend/blob/dev/src/components/sidebar-left.js#L94-L98

image

Vinayakkamble07 commented 2 years ago

Yes I'm able to run the project . But I'm unable to write the required code .

On Sun, Oct 2, 2022, 6:03 PM Filip Czaplicki @.***> wrote:

It's hard to help without some details. Are you able to run project locally? Do you have experience with HTML/CSS/React/JavaScript?

Those buttons should in AED popup details, somewhere on the bottom. Example link: https://openaedmap.org/#map=17/51.158873/21.649783&node_id=9437937877 Footer is defined here: https://github.com/openstreetmap-polska/openaedmap-frontend/blob/dev/src/components/sidebar-left.js#L94-L98

[image: image] https://user-images.githubusercontent.com/2798728/193454062-d1b47ff9-58d3-465d-9fba-1471de7c4ecb.png

— Reply to this email directly, view it on GitHub https://github.com/openstreetmap-polska/openaedmap-frontend/issues/49#issuecomment-1264633080, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWTDT2C2W73JYSLANH66JEDWBF6KNANCNFSM6AAAAAAQQXHFKI . You are receiving this because you were mentioned.Message ID: @.***>