search

openstreetmap / chef

Chef configuration management repo for configuring & maintaining the OpenStreetMap servers.
Apache License 2.0
97 stars 66 forks source link

Include changeset discussion comment ids in changeset replication files #680

Open Woazboat opened 3 months ago

Woazboat commented 3 months ago

Opening an issue here since the replicate-changesets script is seemingly maintained in here instead of in https://github.com/zerebubuth/openstreetmap-changeset-replication (upstream issue: https://github.com/zerebubuth/openstreetmap-changeset-replication/issues/9)

The OSM API recently changed the changeset endpoint to also return the comment id for changeset discussion comments in the api response. The changeset replication should probably be updated to also include this. https://github.com/openstreetmap/openstreetmap-website/pull/4245

<osm ...>
    <changeset ...>
        ...
        <discussion>
            <comment id="1234" ...>
                <text>...</text>
            </comment>
            ...
        </discussion>
    </changeset>
</osm>

https://github.com/openstreetmap/chef/blob/26b959ed598073e88ad23403cbcb3623476342d9/cookbooks/planet/files/default/replication-bin/replicate-changesets#L97-L118

tomhughes commented 3 months ago

Looking at the history here I don't think I was aware that other repo existed - it looks like I found the script running unmanaged on the server and added it here to get it managed without realising there was already a repo for it.