search

openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.36k stars 1.21k forks source link

Intersected buildings are not detected #10137

Open vmartyanov opened 7 months ago

vmartyanov commented 7 months ago

URL

https://www.openstreetmap.org/changeset/147971041

How to reproduce the issue?

I think the screenshot is self-explaining:

image

Screenshot(s) or anything else?

Seems intersection is detected if and only if two lines intersects. But in this case segments have common nodes and this cause no lines intersection. But buildings are definitely intersected!

Maproulette challenge detects it, iD doesn't

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.27.3

Which browsers are you seeing this problem on?

Firefox

k-yle commented 7 months ago

As a side note, I had assumed this behaviour was intentional when I created #10120. If this is indeed a bug, then #10120 will need reworking

vmartyanov commented 7 months ago

Hm, #10120 has different shape: two squares with a common edge

k-yle commented 7 months ago

yeah #10120 is a different arrangement, but my "fix" for that issue assumes that your screenshot is a valid situation.

Anyway, I'm following this thread now, so I can update #10120 depending on what happens here