search

openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.38k stars 1.22k forks source link

Release as Electron app #10162

Open verhovsky opened 8 months ago

verhovsky commented 8 months ago

Packaging iD as an Electron application has two benefits I can think of (besides the obvious)

  1. swiping back with two fingers on a touchpad shouldn't act as a back button like it does on macos. i've lost data because of this
  2. you can have more undo history because localsessionstorage is 50MB instead of 10MB. you could also write to disk and get effectively unlimited history
k-yle commented 8 months ago
  1. This annoying behaviour can be disabled in settings for all apps, or just for chrome
  2. We could easily fix this by using IndexedDB instead of localStorage, then there would be effectively no size limit†. Using IndexedDB would also improve performance, since we no longer need to call JSON.stringify on an a huge object everytime you drag a node. Incidentally, that's one of the biggest performance bottlenecks that I've noticed in iD
verhovsky commented 8 months ago

I'm not going to disable it for Chrome because I like it on all websites except iD.

matkoniecz commented 8 months ago

(besides the obvious)

Which one is obvious for you?

verhovsky commented 8 months ago

less taps to open, less data to load