search

openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.36k stars 1.21k forks source link

Drop down boxes are not cleared #10319

Open danieldegroot2 opened 3 months ago

danieldegroot2 commented 3 months ago

URL

No response

How to reproduce the issue?

  1. Add relation with empty role. (i.e. building relation to building)
  2. Add role. A suggested roles selection shows up. (i.e. outline, outer, ...)
  3. Input role manually (i.e. outline)
  4. Go to another part of the building.
  5. Since no option has been selected from the suggestion 'overlay' the first time, it remains on screen the second time.

Has been happening for longer time.

Screenshot(s) or anything else?

image

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.29.0-live

Which browsers are you seeing this problem on?

Chrome

boxer4 commented 3 months ago

I don't know if this is the same but I've seen drop down boxes not being cleaned up in general, well, specifically the save comments drop down. I would suspect it's the same issue.

As far as I can tell with the save comment box, there is some sort of race condition where context changed but the box was open. I can't reliably reproduce the issue, but it's exasperated by network latency.

danieldegroot2 commented 2 months ago

Related https://github.com/openstreetmap/iD/issues/8403#issuecomment-799839777 (workaround)