search

openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.38k stars 1.21k forks source link

Panoramax: Dense sequences #10379

Open danieldegroot2 opened 3 months ago

danieldegroot2 commented 3 months ago

Description

Ref #9941 Especially for Panoramax, since it may introduce more of these ( + RTK ) (though Mapillary does NerF w/ them)

Sometimes quite dense traces may occur for which you may have to zoom in further than normal to avoid trace clutter.

Let's zoom in to this roundabout. (but let's skip to the proper zoom level)

https://ideditor.netlify.app/#background=fr.ign.bdortho&disable_features=boundaries&map=18.00/-20.91730/55.54240&photo_overlay=panoramax Zoom 18: There is the directional cones. This happens to be quite a dense trace, so everything is overlapping

https://ideditor.netlify.app/#background=fr.ign.bdortho&disable_features=boundaries&map=20.00/-20.91730/55.54240&photo_overlay=panoramax Zoom 20: Cones are still overlapping other bubbles.

https://ideditor.netlify.app/#background=fr.ign.bdortho&disable_features=boundaries&map=21.00/-20.91730/55.54240&photo_overlay=panoramax Zoom 21: Looks like the normal situation again(no overlaps). Zoomed in slightly further than normal for this perhaps. Could some bubbles be hidden still / set a max. frequency (optimized, but confusing)? Or, maybe a slider for how frequent we want to see an image(only sometimes useful)? Or, should the Panoramax team be contacted to ask if there are not too many? (though, I consider this not completely spam trace, especially since it is taken as regular single direction image. If a barrier blocks view in urban area you may miss something if it were less dense.)

Sidenote: I believe this is originally a Mapillary trace (so the same goes for Mapillary, but I am probably extra aware now).

Chrome 127.0.6533.89 on Windows 10

Screenshots

image Zoom 19: It may appear like a large paint brush hit the screen to some users.

Which deployed environments do you see the issue in?

Development version at ideditor.netlify.app

What version numbers does this issue effect?

2.30.0-dev

Which browsers are you seeing this problem on?

Chrome

Related #5482, #3152

mattiapezzotti commented 3 months ago

One possible solution would be to limit the number of bubbles that can be drawn on top of eachothers, however this will hide some bubbles and make a little weird moving between images with the arrows

Since just zooming it fixes the problem, I don't see it being changed, but we'll see

tyrasd commented 3 months ago

we do already limit the number of markers drawn "per tile" (see here). This could be made configurable by the user, but I'd say it's probably hard to convey this well in a UI.

I'd say that #10321 might help to reduce the issue with blocked visibility of underlying aerial imagery and/or OSM map features.

Cones are still overlapping other bubbles

I wouldn't say that this overlap is necessarily an issue: As the cones of a single sequence are typically not changing too much between two consecutive photos (especially not for sequences with small time interval between photos), the cones are still well enough indicating the direction of the photos of the respective sequence.

[…] weird moving between images with the arrows

Btw: In 136308821, I've fixed that the active image marker was sometimes not rendered due to this limit.