openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.34k stars 1.2k forks source link

Panoramax: Connection between unrelated sequences #10423

Open danieldegroot2 opened 3 weeks ago

danieldegroot2 commented 3 weeks ago

URL

No response

How to reproduce the issue?

Ref https://github.com/openstreetmap/iD/issues/9941

At https://www.openstreetmap.org/edit#map=20/52.4079271/-7.0562329

~~https://api.panoramax.xyz/#pic=5bcbb8c0-5fbb-4841-8ca8-fc82bfbed7a4&focus=pic incorrectly connects to https://api.panoramax.xyz/#pic=a9a3759f-9888-4ed5-bd0f-e47af4842b8b&focus=pic (unless you would like to connect recent sequences)~~

~~Correctly indicates it is an unrelated sequences; no forward/backward possible in viewer itself Correctly disconnected by Mapillary.~~ Edit: Has the same sequence identifier in the Panoramax API. See below comment instead.

No errors generated by Panoramax.

Chrome 128.0.6613.85 on Windows 10

Screenshot(s) or anything else?

image

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit, Development version at ideditor.netlify.app

What version numbers does this issue effect?

2.30.2, 2.31.0-dev

Which browsers are you seeing this problem on?

Chrome

tyrasd commented 3 weeks ago

At first glance, this appears to be a "bug/issue" on the panoramax API side: Both images have the same sequence_id:

image

I assume this is actually the expected behaviour, as here the user has likely uploaded all the images as a single sequence on purpose. The only proper "bug" seems to be that there are no prev/next links between the two mentioned photos (see example screenshot below), likely caused by the fact that the photo type switches from a 360° panorama to a regular photo. //cc @cquest

image