Allow multiselection of search results

[jidanni]

Description

Here the user wishes to multiselect all these search results.

So perhaps add checkboxes, or allow SHIFT+CLICK or CTRL+CLICK.

Screenshots

[draunger]

@jidanni can i do start work on this issue, I am new here and I want to do this issue?

[draunger]

@jidanni I think I can solve this issue

[jidanni]

That's great. I'm sure the team will love your fix.

[draunger]

@jidanni you are asking for multiselect for highlighting the map ?? means when hover only one search result some part of the map become highlighted so you want this that on multiselect the result the item which are selected must be highlighted ??

[draunger]

@jidanni i have raised a PR https://github.com/openstreetmap/iD/pull/10497 against this issue as described in it , you can review this PR as soon as possible thank you.

[1ec5]

I'm sure the team will love your fix.

@jidanni, please don’t speak for the development team. The maintainers of this repository haven’t weighed in on your feature request, which means it isn’t necessarily something that will be accepted. You’re doing @draunger a disservice by prematurely asserting that it will be.

[draunger]

@1ec5 what I do now? Is my PR is now waste of time?

[1ec5]

Hi @draunger, thanks for submitting a PR, and sorry that you were misled. Please be patient while the maintainers work through the very large backlog of issues and PRs. It’s possible that they may agree with the feature request, but there’s no guarantee. In the meantime, the issues in https://github.com/openstreetmap/iD/labels/good%20first%20issue have been identified by others as good issues for familiarizing yourself with the iD codebase, hopefully without getting into any controversy.

[jidanni]

@jidanni you are asking for multiselect for highlighting the map ?? means when hover only one search result some part of the map become highlighted so you want this that on multiselect the result the item which are selected must be highlighted ??

All I know is I wanted to change the name of all the items I saw in that search result. I wanted to correct it by adding the same missing character to every single name. So multi-select is what I needed.

Sorry for being too optimistic about team policies. Okay next time I won't make the same mistake.

[tyrasd]

This does sound like a feature one would reasonable expect to exist in iD, and would be useful for many use cases such as the one mentioned above:

I wanted to change the name of all the items I saw in that search result.

It would not be hard to implement a multiselection in the search result lists (see https://github.com/openstreetmap/iD/pull/10497, anthough I would have preferred a ctrl-click/long-click pattern instead of checkboxes), but the tricky part (UI/UX wise) here is to create a mechanism to get from the list of search results to a multiselection of OSM features. Currently, this is done on click, but that would not be possible anymore if the search results should remain visible to be able to select more. And at the same time we don't want to complicate the more often used workflow of directly selecting a single search result. :thinking:

[jidanni]

Perhaps give the best of both worlds. The Ctrl, shift multi-select people could ignore that there are checkboxes because Ctrl, shift, etc. multi-select would still work. And then the checkbox people could just select their checkboxes too and that would work also.