search

openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.38k stars 1.21k forks source link

Warning on building=roof #10470

Open alesarrett opened 2 months ago

alesarrett commented 2 months ago

URL

No response

How to reproduce the issue?

When creating a building=roof, iD is raising a warning if a layer=1 is not entered, even if the roof is not intersecting any other feature. Anyway in the wiki is clear that layer=1 should be used when 2 or more features overlap, to express vertical positioning. Also the wiki page for roof is describing the use of the key layer only when roof is overlapping with something else: https://wiki.openstreetmap.org/wiki/Tag:building%3Droof So, why this requirement and warning on iD?

Screenshot(s) or anything else?

Screenshot_20240920_115017

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

No response

Which browsers are you seeing this problem on?

Firefox

k-yle commented 1 month ago

This change was introduced in https://github.com/openstreetmap/id-tagging-schema/pull/227

alesarrett commented 1 month ago

Thank you for the reference, but that issue pertains to cases where a highway is located behind the roof. If the warning is applied as a default for all building=roof, inexperienced users may add a layer=1 unnecessarily, which does not align with the guidelines provided in the wiki. Could the warning be implemented only when the roof intersects with an already existing highway? This would effectively draw the user's attention when it is truly needed.

k-yle commented 3 weeks ago

@alesarrett what you're describing is the old behaviour, before openstreetmap/id-tagging-schema#227 was introduced