openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.

https://www.openstreetmap.org/edit?editor=id

ISC License

3.38k stars 1.21k forks source link

description related to tag starting with name is removed #10521

Open draunger opened 3 weeks ago

draunger commented 3 weeks ago

Description:

approach

i have used slice method which slice the key which are starting with name and checks the condition after slicing

attached screenshot after the fix

before this fix

attached issue

https://github.com/openstreetmap/iD/issues/10287

Dimitar5555 commented 2 weeks ago

I've just did a quick test and it seems like you can add name: true to this list and it will catch all name:xx variants, without all of the extra code you added. It is likely using some sort of regex under the hood, but I haven't looked for it.

https://github.com/openstreetmap/iD/blob/49492a0e06aef71f90e96ab3ed50098df0f4ce93/modules/services/taginfo.js#L196-L209

draunger commented 2 weeks ago

@Dimitar5555 i did this before but it does not working

draunger commented 2 weeks ago

@1ec5 please review my PR so that i can make changes