openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.3k stars 1.19k forks source link

Redesign, fixup markers #172

Closed tmcw closed 11 years ago

tmcw commented 11 years ago

So lots of directions here:

Refs:

drawMarkers: https://github.com/systemed/iD/blob/master/js/id/renderer/map.js#L185

samanpwbb commented 11 years ago

In order to replace the current marker set, we'd need an alternative for every icon here: https://github.com/systemed/iD/tree/master/icons

Maki is already well on its way to covering all these icons, but I would need to make a few dozen additional symbols. Here's what needs to be added to Maki in order to be able to fully replace the current icons set:

POI icons

abnormal icons

Repeating patterns

Shields All the shields (?)

Maybe

This should probably be sprited, but an alternative would be to render the SVG's in browser. Would this be hard on performance? The advantages are that markers would be easier to style and scale.

@tmcw do you know why there are so many duplicate icons? there is airport.png and then airport.p.16.png for example, but they're both identical. Also, do you know if all of the icons are being used?

lxbarth commented 11 years ago

@samanpwbb - how long would it take you to make all the missing icons?

samanpwbb commented 11 years ago

@lxbarth two weeks.

jfirebaugh commented 11 years ago

We're now using maki icons, matching the presets. Still needs some design attention though. I couldn't quite get the icon centered, and I'd like to see what a reverse teardrop shape looks like.

jfirebaugh commented 11 years ago

Here's how they look with a traditional marker outline:

image

I think this contrast better with how we're now rendering tagged vertices.

image

(Those traffic signals need a maki icon.)

talllguy commented 10 years ago

@samanpwbb The icons link is now dead. Is there a new one?

samanpwbb commented 10 years ago

@talllguy not sure- that was a repo maintained by @systemed

I wasn't paying attention :) Let me look.

jfirebaugh commented 10 years ago

Current equivalent link would be something like https://github.com/openstreetmap/iD/tree/3744ca602d5329426f5516189c25aae46a4341e9/icons

samanpwbb commented 10 years ago

@talllguy what are you looking for? Maki has far surpassed where it was when we had this conversation.

talllguy commented 10 years ago

Thanks gentleman! I was actually interested if there was a military related icon, for my #2177 issue, so I was looking for an icon / maki to go along with that.