search

openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.38k stars 1.21k forks source link

iD's Locator overlay shows things at null island #2751

Closed SomeoneElseOSM closed 8 years ago

SomeoneElseOSM commented 9 years ago

If you go to https://www.openstreetmap.org/edit?editor=id#map=13/-0.0068/0.0278 with iD's locator overlay enabled, you notice "Black River", "Blue Street" etc.

They probably shouldn't be there.

bhousel commented 9 years ago

@ericfischer is the Mapbox locator overlay something you know about? I know it probably lags the data by a little while, and there is no garbage data showing there now.

SomeoneElseOSM commented 9 years ago

Actually, the most recent "Blue Avenue" was pretty recent:

http://www.openstreetmap.org/way/364466827/history

I've added a changeset discussion comment to try and track down the source. It doesn't look like learnosm's (no "Cat Forest" etc.).

http://www.openstreetmap.org/changeset/33173056

e-n-f commented 9 years ago

The locator overlay style might be pointing at an old data source. I'll check when I get to the office.

bhousel commented 9 years ago

@ericfischer any update on this?

e-n-f commented 9 years ago

All I can say for sure is that it's not in general pointing to old data because it has picked up recent changes of mine like this one. This tile must have failed to update some other way and I'll try to figure out how.

bhousel commented 8 years ago

With 2d987a3, I'm blacklisting null island data from the iD side, as it doesn't look like it can be fixed easily upstream.

SomeoneElseOSM commented 8 years ago

Re https://github.com/hotosm/learnosm/issues/335 ("Cat Forest" etc.), Learnosm have created a JOSM ticket for it: https://josm.openstreetmap.de/ticket/12731 .

bhousel commented 8 years ago

@SomeoneElseOSM, yes edits have appeared here and been cleaned up, but there is some issue with generating the overlay tiles that makes it unlikely for this to get fixed soon.

I also found that it's a good idea to blacklist Mapillary data around here too.