search

openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.36k stars 1.21k forks source link

Support for lane and turn lane tagging #387

Open simonpoole opened 11 years ago

simonpoole commented 11 years ago

The road style should reflect the number and type of lanes added.

Further a smplified method of tagging lanes should be available.

See http://wiki.openstreetmap.org/wiki/Key:lanes and http://wiki.openstreetmap.org/wiki/Key:turn

quincylvania commented 5 years ago

@BjornRasmussen said:

I have a simple UI suggestion: make the editor have two sections, a visualizer that can let you select lanes and lane dividers, and an editor for specifying lane information for the selected lane/divider.

Yep, I was thinking something like this as well. Either below the lanes, or as I said in my one comment, "You would click on a lane to open an editing popover." This could also apply to dividers if the OSM tagging is that far developed.

@tordans said:

I also feel like the community is slowly pushing towards tagging separate was for separate traffic sources.

I'm all for this! I vastly prefer separate sidewalks and even bike lanes, but if people keep tagging this stuff on roads then I do think it makes sense to show them in the lane layout.

The other issue is, that having a UI that handles the lanes is one thing. But the same UI should also allow to add all the descriptive sub-tags as well.

We can start with the basic lane info (access, turns) and see what makes sense after that. The point is to make lane-tagging possible and easy, not to do everything 😅

tordans commented 5 years ago

The point is to make lane-tagging possible and easy, not to do everything 😅

I am glad to hear that.

That would mean, we can now find the best solution to handle the following tags, right?

and

Source: https://wiki.openstreetmap.org/wiki/Key:turn#Example_for_a_road_with_both_directions

But also destination tags? - https://wiki.openstreetmap.org/wiki/Key:destination Anything else?

So we need to be able to …

If so, the first question for the UI is IMO:

BjornRasmussen commented 5 years ago

should it display the lanes on the road (in the map view) (#387 (comment) and maybe #387 (comment)).

or: should it handle the details in the sidebar (#387 (comment) and similar).

or: both, but the map to show it, the sidebar to edit it?

I would prefer both, with the option to turn rendering of lanes situated next to the wireframe option in map data.

BjornRasmussen commented 5 years ago

But also destination tags? - https://wiki.openstreetmap.org/wiki/Key:destination

I think that it would be too difficult to work this into the interface, but maybe would fit somewhere in the pop-up.

EmpireFall commented 5 years ago

Edit - after reading all the comments regarding this issue, it has occurred to me that a lot of commenters are arriving at the same sort of concerns regarding the challenges behind creating an interface for solving this issue, what I typed-up below is essentially a rephrasing of ideas that commenters have already come up with (I had yet to actually read all of the previous comments regarding this issue at the time when I wrote it, it looks like we are all more or less on the same page)

I was designating 'turn:lane' tags for 'ways' using the current iD editor, it requires a certain amount of focus to get right, otherwise the user may confuse the direction of the 'way' with the intended direction of the 'tag' in conjunction with the road markings seen in the background layer (as the forward heading direction of a 'way' is defined by the direction in which it is drawn, there have been times that I have mistakenly assumed that the forward heading direction of the way is the same as the side of the road in which traffic flows, which has led me to designate tags accordingly only to realize later that the heading of the way is in reverse, that coupled with a background layer that is always facing upright can make designating turn:lane tags a rather focus intensive process)

in this regard, a function in the iD editor that came to mind, that I thought was rather intuitive is the 'turn restriction' box

would it not be possible to present the 'turn:lane', 'parking:lane', 'road markings, etc' tags for each respective lane with similar presentation and functionality of the 'turn restriction' box?

if the angle for each symbol of each respective lane tag were facing the same orientation as the 'way' itself (as seen in the turn restriction box), that would make it much easier for the user to orient themselves with the respective tags of each lane in conjunction to the orientation of the 'background layer'

https://i.imgur.com/PJxpPip.jpg https://i.imgur.com/96k12Rj.jpg

as the orientation in which a 'way' can be either 'forward' or 'backward' and angled toward any direction, having a box with all the lane details presented facing upwards (as shown in the image below), the user may end up feeling as disoriented as with the current setup available in the iD editor

https://i.imgur.com/vhNHga0.png

imagine designating 'turn restrictions' if the orientation of the 'way' in the turn restriction box were facing upright rather than at the orientation of the way itself, things could get rather confusing without a certain amount of focus

just a thought

hungerburg commented 3 years ago

Removing the WIP label usually means, the feature is complete. Can I get my hands on a working testbed?

kymckay commented 3 years ago

@hungerburg Removal of WIP just signifies work is no longer actively in progress. There'd be a lot more buzz on this issue if the feature was complete 😄

hungerburg commented 3 years ago

Is the abandoned work of Quincy's open source? Recently someone did some lane tagging in the area of my local_knowledge with iD and I think, they mostly did that manually, at least not all the stuff passes validation, so I think that it be worthwhile to continue that work, the screenshots looking very nice indeed.

reticivis-net commented 1 year ago

bumping this issue because there's multiple designs and working prototypes and I really want to see this integrated into iD. JOSM's turn lane plugin sucks

Zaczero commented 1 year ago

@HexCodeFFF, I think that's a trend with iD development in general. I wouldn't get my hopes up. I completely gave up on any iD contributions a few weeks after posting this thread: https://github.com/openstreetmap/iD/issues/9500

reticivis-net commented 1 year ago

Damn. Sucks cause iD is, imo, much cleaner and easier to use than JOSM but there's no plugins and slow development.

dabreegster commented 1 year ago

Putting in a plug for https://github.com/a-b-street/osm2streets/issues/216 -- we have a web app for visual lane tagging started. Could use help with getting OAuth to work, and with design/implementation for a nicer UI to edit (rather than raw tags). Happy to adapt/use one of the designs from earlier in this thread -- better to get something going and iterate quickly. Screenshot from 2023-05-30 23-31-36