search

openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.37k stars 1.21k forks source link

Mapillary Placement Tools #4426

Open amahon opened 7 years ago

amahon commented 7 years ago

Building from SfM reconstructions that Mapillary generates everywhere we have imagery, it's possible to edit map data by placing and editing points in an image.

The pattern, deemed Placement Tools, is demonstrated by an example found in the Mapillary.JS documentation.

The functionality is expressed in a Mapillary add-in for ArcGIS Pro: image

Currently, Mapillary.JS only supports placing and editing points in imagery. Forthcoming, but unscheduled, is support for linestrings and polygons.

Also, one caveat, Placement tools are only as good as Mapillary's underlying data is. In places like Amsterdam, where Mapillary has high quality imagery with very good GPS data, Placement Tools work fantastically. In areas where imagery/gps data is not as good, Placement Tools will not perform as well.

Let's think about how we can bring this functionality into iD Editor to allow OSM editors to place and edit nodes via Mapillary Imagery.

amahon commented 7 years ago

@bhousel - let me know what you think and how I can help!

bhousel commented 7 years ago

Very cool, this will make mapping objects so easy 👍

planemad commented 7 years ago

Having this will completely unleash a new wave of detailed editing on OSM. I'm going to immediately use it for tree mapping when its out!🌲🌲🌲

tordans commented 6 years ago

@amahon I saw a presentation about this (YouTube) and would love to see this feature live. What is the status? What is the timeline? Who is writing the code to get it into iD?

Update: I tested the placement tool and ATM I don't think its working accurately enough to use it as part of the editor. See https://github.com/mapillary/mapillary-js/issues/272.

amahon commented 6 years ago

@tordans - thanks for your questions!

Right now, we're working on implementing an API that will allow iD editor to access the detection data. I don't have an up to date timeline that I can share. Last discussed, which is a while ago now, Mapbox would implement the new features in iD -- since so much time has passed, I need to loop back and assess priorities with @bhousel. Will post an update here.

Let me know if I can help with anything else!

tordans commented 6 years ago

@amahon any news about this?

tordans commented 5 years ago

I noticed a surge of attention for this feature (outside of iD). For for reference, a few links:

todrobbins commented 5 years ago

@amahon @cbeddow the people demand SfM tooling! 🛠

At least there's https://osm.cycle.travel/deriviste/ for now

cbeddow commented 5 years ago

Yes, Deriviste is a good example of how it can work. It also is in the go2mapillary plugin for QGIS, in case another example is needed. I wouldn't personally develop this for iD editor as Deriviste is way more simple for me to work with and OSM iD usually over my head, but if anybody is looking to add it I'm totally open to advise!