Indoor mode buttons

[zbycz]

Hi,

thanks to discussion in https://github.com/openstreetmap/iD/issues/4772 I am again considering porting my indoor-mode to the current iD version.

But back then we had an issue with the button placement. What is the current idea? where does it belong? (Also is there any progress on iD taskbar #3123?)

I think you said earlier, that the context menu could be the right place - I am not sure. The icon button would be unclear until hover, and too many functions there arent good? Also it should be shown only when right-clicking a building? I thought about better placement and inspector panel seems ok. For every building=* there could be a button saying "Indoor mode"... what do you say?

And what about level-switcher/exit-button? Could it be in the top toolbar as I propsed originally? See the original editor here: http://zby.cz/thesis

[manfredbrandl]

The issue #3123 has the milestone tag 2.8 got attached two weeks ago. Its the only issue with this milestone tag. The milestone 2.7 hat the single issue feature "support turn restrictions via way" which @bhousel is actively working on just now, so it may be not so far until the iD taskbar may make progress. Of course it is up to Bryan.

[billtheblindlion]

Commenting on #4780, I am in favor of having ID-indoor as part of the ID editor. I believe indoor mapping will be an important item for OSM in the future. I especially like the web based editors because all of the accessibility features work with the browser], which is not necessarily true for other types of editors. Accessibility features let people who are partially sighted use the web based editors. This will allow people who are partially sighted/low vision help develop map solutions which will help the blind/low vision community.

[manfredbrandl]

2.7 was published recently, so work on milestone 2.8 and the iD taskbar is opened. @zbycz and @panieravide are you intrested in porting indoor-mode to the main iD editor now?

[PanierAvide]

Great :-) Well for now I'm quite busy to help, but I'm still interested in seeing indoor mode being available in iD.

[zbycz]

I would like to work on the implementation, but i still dont know where could i place the entry button. Who is the one to decide?

[manfredbrandl]

@zbycz i think @bhousel could decide.

[bhousel]

I really don't have a place for this to go just yet - thanks for being patient!

[prototype99]

i feel like really, it might be best having it as a right click option on buildings? simply because theoretically you would never need indoor features outside of a building. or at least that's how i see it. the level option probably makes the most sense grouped with the zoom and show my location buttons as it is also a navigation feature and there are even cases outside of the purely indoors where you might want to see just one level (think underpasses for example). it probably makes sense to display the ground level by default, and maybe have the other levels display as different washed out(probably just the layers directly underneath/below otherwise city areas could get chaotic to render... on a sidenote that would help prevent indoor mapping from creating too much lag as it would effectively only be rendering 3 layers at a time, and as basements aren't too common it's probably more accurate most of the time to say 2), uneditable layers so that you can still view them for context? and maybe you can still connect points to them, just you can't select them (fixes #2225 ). outside of editing mode obviously it's still quite useful to see 'greyed out' outlines of other levels (especially relating to objects such as bridges etc. that might serve as useful waypoints when consulting the map)

[manfredbrandl]

Can we have the indoor mode inside the object editor wenn used with a building? Similar to the restrictions editor for crossroads?

[danielsjf]

Is this still on the Roadmap? iD has seen a lot of useful updates that aren't available in the iD indoor version so at the moment we have two tools with different merits. For consistency reasons it would be good if they could be merged.

[PanierAvide]

This will not solve the issue of having two different tools, but at least the indoor tool will be far more suitable. Still under development, but official release for the end of September : https://framagit.org/PanierAvide/osminedit

[danielsjf]

Cool, what are the main changes compared to iD indoor?

However, I would still argue that it could be beneficial to also bring iD up to speed. Occasionally, issues with indoor maps do arise (like #6800). This will only get worse since in buildings with many floors, many POIs could end up on top of each other. This would make it hard to edit them in the current version of iD.

[PanierAvide]

Key features are integrated tool for managing images of floor plans, simple UI designed for managing indoor data, advanced presets... I will give a talk about this at next State of the Map in Heidelberg, in case you are attending.

Still, you're right that it will be beneficial for everyone to see at least a very basic indoor support in iD (mostly what iD-indoor was doing : level filtering + proper presets for indoor features).

[bhousel]

Is this still on the Roadmap? iD has seen a lot of useful updates that aren't available in the iD indoor version so at the moment we have two tools with different merits. For consistency reasons it would be good if they could be merged.

At this point my focus is on rethinking iD's architecture to make things like this easier. This means we probably won't be merging any big new features into main iD for a while. See our talk from SOTM-US last weekend! https://2019.stateofthemap.us/program/sat/id-v3.html

@quincylvania will be in SOTM-Heidelberg, so you should connect with him!

[danielsjf]

No unfortunately I won't be there, even though the subjects look very interesting. I'll have a look at the video of the talk. Thanks.

@panieravide, I'm looking forward to the release. Will it also be hosted somewhere? Especially the floor plan support will be really good. Many places (e.g. Airports) have good maps, but at the moment it is very difficult to get them to overlay.

[PanierAvide]

@danielsjf You can try test version here (switched on OSM development server, you have to create a separate account if you don't have one, and only few data exists) : https://osminedit.pavie.info/dev/

[TheAdventurer64]

Progress?